Multiple str_format at Linux?

Deleted.

The problem is, on windows i can use multiple lines and the command ingame show all lines without problems.
On linux it shows only the last line.

yeah right, xD
Mhmm i fixxed it with a query for Windows and Linux because of the different buf sizes.
for Windows i use this:
str_format(aBuf, sizeof(aBuf), "I am %s, ", "not gay");
str_format(aBuf, sizeof(aBuf), "\nvery very %s", "not gay");
and linux:
str_format(aBuf, sizeof(aBuf), "I am %s, \nvery very %s", "not gay", not gay);

it works, so~

When you want to append a string to an other, why do you not use str_append which is also part of the baselib?

char aBuf[128] = {0};
str_append(aBuf, "Hello?", sizeof(aBuf));
str_append(aBuf, " Yes, this", sizeof(aBuf));
str_append(aBuf, " is dog.", sizeof(aBuf));

then aBuf contains "Hello? Yes, this is dog."

zCatch Mod  |  TW+ Mod

You have to use the buffer before you overwrite it:

str_format(aBuf, sizeof(aBuf), "Kills: %d", playerkills);
SendChatTarget(ClientID, aBuf);
str_format(aBuf, sizeof(aBuf), "Deaths: %d", playerdeaths);
SendChatTarget(ClientID, aBuf);

And you have to use %d for numbers in str_format or your server will crash.

If this is really the case (wich I completely doubt), then this is a bug on the windows side. str_format will write into the buf from it's very begininng (the address aBuf is pointing to) regardless of the fact if there is something in it, so it's only natural that the first message doesn't get printed.

What you can do is either put both stuff into the string with str_format(aBuf, sizeof(aBuf), "%s\n%s", first_string, second_string) (don't know how \n will work in the default chat though) or send twice. Both methods have been suggested before, and i believe the only proper one is the second one. So in fact, you should do it like this:

str_format(aBuf, sizeof(aBuf), "Kills: %d", playerkills);
SendChatTarget(ClientID, aBuf);
str_format(aBuf, sizeof(aBuf), "Deaths: %d", playerdeaths);
SendChatTarget(ClientID, aBuf);

So you do  this on the server side with

str_format(g_Config.m_SvMotd, sizeof(g_Config.m_SvMotd), "Kills: %d", playerkills);
str_format(g_Config.m_SvMotd, sizeof(g_Config.m_SvMotd), "\nDeaths: %d", playerdeaths);

?
There are different problems with this code:
1. As mentioned before, the first "message" will simply be overwritte and won't be shown at all in most cases (usually all)
2. You can't be sure that the "message" get's sent at all, before it get's updated again (assuming that it get's updated everytime a kill/death happens). Changing the motd does not necessarily mean the new motd get's sent to the clients. I believe that clients will ask if there is a new motd after a certain amount of time, but I'm not sure about that. When changing the motd via rcon console (sv_motd "This is the new motd") a callback function (ConchainSpecialMotdupdate) get's called that makes sure the new motd gets sent to all clients and I think this is the approach you should take, too, if you really want to put this stuff in the motd. However, using the already exsisting function is probably a bad idea, because it uses all that callback stuff and you probably don't want to mess with that. I suggest to write a new function in gamecontext.h/.cpp:

void CGameContext::SendMotd()
{
    CNetMsg_Sv_Motd Msg;
    Msg.m_pMessage = g_Config.m_SvMotd;
    for(int i = 0; i < MAX_CLIENTS; ++i)
        if(m_apPlayers[i])
            Server()->SendPackMsg(&Msg, MSGFLAG_VITAL, i);
    return;
}

This is exactly what ConchainSpecialMotdupdate does when you remove all that callback stuff and so on.

Your code for updating the motd the way you want should then look like this:

char aBuf[64]; // or whatever size you need...
str_format(aBuf, sizeof(aBuf), "Kills: %d", playerkills);
str_copy(g_Config.m_SvMotd, aBuf,  sizeof(g_Config.m_SvMotd));
str_format(aBuf, sizeof(aBuf), "\nDeaths: %d", playerdeaths);
str_append(g_Config.m_SvMotd, aBuf,  sizeof(g_Config.m_SvMotd));
m_pGameServer->SendMotd(); // assuming m_pGameServer is a pointer to the gamecontext

You could of course combine those two str_formats, which I recommend, to me it looks cleaner that way, but from what I read in that post, you don't want to do that for some reason.

The code I posted should work the way it is, but I don't guarantee that there are no mistakes and stuff in it. I did not test it. Also it should be more of a guideline to what you should be doing instead of giving you the only possible solution. I hope I could help you with this.

You abuse the way the function works on windows, but there's no guarantee that it will work like that on other libc implementations aswell.

Similar code:

char aDataToSend[128];
char aBuf[16];

aDataToSend[0] = 0;
str_format(aBuf, sizeof(aBuf), "bar: %s", "foo"); str_append(aDataToSend, aBuf, sizeof(aDataToSend));
str_format(aBuf, sizeof(aBuf), "wtf: %s", "ftw"); str_append(aDataToSend, aBuf, sizeof(aDataToSend));