1 Topic by FreshCola

  • FreshCola
  • FreshCola
  • Member
  • Offline

Topic: [HELP] is teeworlds healthy?

wtf is going up today? i am searching a server click it on and BAM..wait no BAM just nothing ~~ have to close... try to open again again same thing ~~

a teefriend had same problem like me... wth had happend?

dont be hard with me:i am just a softdrink xD

2 Reply by Kottizen (edited by Kottizen 2010-05-28 17:20:11)

  • Kottizen
  • Kottizen
  • Administrator
  • Offline

Re: [HELP] is teeworlds healthy?

There is a tee out there who got evil and decided to close the game.

3 Reply by KaiTee

  • KaiTee
  • Member
  • Offline

Re: [HELP] is teeworlds healthy?

FreshCola, use Sushis Clientpack or the refractor version, that fixes the problem.

Visit tee-league.de and tv.tee-league.de!

4 Reply by Sushi Tee

  • Sushi Tee
  • Sushi Tee
  • Donor
  • Offline

Re: [HELP] is teeworlds healthy?

easy fix:

Index: src/engine/client/ec_client.c
===================================================================
--- src/engine/client/ec_client.c    (revision 2337)
+++ src/engine/client/ec_client.c    (working copy)
@@ -956,6 +956,11 @@
                 info.progression = atol(unpacker_get_string(&up));
                 info.num_players = atol(unpacker_get_string(&up));
                 info.max_players = atol(unpacker_get_string(&up));
+                
+                // don't add invalid info to the server browser list
+                if(info.num_players > MAX_CLIENTS || info.max_players > MAX_CLIENTS)
+                    return;
+                    
                 str_format(info.address, sizeof(info.address), "%d.%d.%d.%d:%d",
                     packet->address.ip[0], packet->address.ip[1], packet->address.ip[2],
                     packet->address.ip[3], packet->address.port);

its actually just copied from the refactor branche but this will fix the error in 0.5 wink

uptee - a simple web interface for hosting and maintaining teeworlds servers
teerace - a website gathering results of trusted Race-mod servers providing global ranking and statistics
*gV* rox ^^

5 Reply by Deleted User (edited by Deleted User 2010-05-28 21:29:13)

  • Deleted User
  • Guest

Re: [HELP] is teeworlds healthy?

Sushi Tee wrote:

easy fix:

Index: src/engine/client/ec_client.c
===================================================================
--- src/engine/client/ec_client.c    (revision 2337)
+++ src/engine/client/ec_client.c    (working copy)
@@ -956,6 +956,11 @@
                 info.progression = atol(unpacker_get_string(&up));
                 info.num_players = atol(unpacker_get_string(&up));
                 info.max_players = atol(unpacker_get_string(&up));
+                
+                // don't add invalid info to the server browser list
+                if(info.num_players > MAX_CLIENTS || info.max_players > MAX_CLIENTS)
+                    return;
+                    
                 str_format(info.address, sizeof(info.address), "%d.%d.%d.%d:%d",
                     packet->address.ip[0], packet->address.ip[1], packet->address.ip[2],
                     packet->address.ip[3], packet->address.port);

its actually just copied from the refactor branche but this will fix the error in 0.5 wink

The attacker can use -1/-1 players. This will even cause the revision 2337 to crash.